e2e: Attempt to fix flaky tests #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to fix flaky tests, which is really hard as they are not reproducible on either local run or PR deployments. The await for `networkidle` timed out a couple of times on the docs tests, so I've attempted to just remove it. It was added in the first place because the dialog loads an image asynchronously, but maybe there is no need for an extra wait here. We've also had a failure in the playground tests where that I saw in the same way before I added the delay for the animation which should only take 200ms, but maybe 300ms as enough extra little wiggle room.
juliaogris
force-pushed
the
e2e-fix-attempt
branch
from
4b4f2d3
to
f14d204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix flaky tests, which is really hard as they are not reproducible
on either local run or PR deployments. The await for
networkidletimed outa couple of times on the docs tests, so I've attempted to just remove it. It
was added in the first place because the dialog loads an image
asynchronously, but maybe there is no need for an extra wait here.
We've also had a failure in the playground tests where that I saw in the same
way before I added the delay for the animation which should only take 200ms,
but maybe 300ms as enough extra little wiggle room.
just deployed manually against evytest.dev and it ran e2e against it which worked as expected, but who knows....