docsite: Add syntax coloring #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
force-pushed
the
syntax-coloring
branch
from
25cc406
to
fb51f58
Compare
|
firebase-deployment for 3d18ece |
Factor out evy syntax highlighting for reuse in docs. Initially we will not use an editor in the docs so all we need to do is replace the <pre><code> codeblocks with the highlighted content.
juliaogris
force-pushed
the
syntax-coloring
branch
from
fb51f58
to
7de2302
Compare
juliaogris
force-pushed
the
syntax-coloring
branch
from
7de2302
to
c513144
Compare
Add syntax coloring to docsite now that we have factored it out of the playground. This requires that we replace ```evy:out and ```evy:err and ```evy:in tags with valid CSS classnames: `evy-out`, `evy-err` and `evy-in` in build-tools/md. Additionally we need to use the query selector `language-evy` to select all evy code blocks, because rsc.io/markdown doesn't allow us to override the classname used for codeblocks and reimplementing markdown.CodeBlock.PrintHTML is not possible without copying big blocks of code - so we have to work with the classname `language-evy` and `language-evy-out` for the time being. We also need to link highlight.js and syntax.css with with the docs site and update the the template in build-tools/md. docs/index.js has a little addition of applying highlightEvy to all its code blocks. Commit-group: 1/2
Add syntax coloring to docsite now that we have factored it out of the playground. This requires that we replace ```evy:out and ```evy:err and ```evy:in tags with valid CSS classnames: `evy-out`, `evy-err` and `evy-in` in build-tools/md. Additionally we need to use the query selector `language-evy` to select all evy code blocks, because rsc.io/markdown doesn't allow us to override the classname used for codeblocks and reimplementing markdown.CodeBlock.PrintHTML is not possible without copying big blocks of code - so we have to work with the classname `language-evy` and `language-evy-out` for the time being. We also need to link highlight.js and syntax.css with with the docs site and update the the template in build-tools/md. docs/index.js has a little addition of applying highlightEvy to all its code blocks. Gen-command: make docs && make snaps USE_DOCKER=1 Commit-group: 2/2
juliaogris
force-pushed
the
syntax-coloring
branch
from
c513144
to
3d18ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add syntax coloring to docsite. This PR required factoring out all syntax
coloring related bits from the playground CSS and module/editor.js.
https://evy-lang-stage-docs--314-elz1ivtw.web.app/syntax_by_example.html