-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bytecode: Implement while and break statements #324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firebase-deployment for ba682c9 |
Rossiar
commented
Apr 4, 2024
Rossiar
commented
Apr 4, 2024
camh-
reviewed
Apr 4, 2024
camh-
reviewed
Apr 5, 2024
camh-
reviewed
Apr 7, 2024
The bytecode for a while statement is similar to that produced for an `if`, except that the OpJump points to the start of the statement and not the end. Break statements are also jumps to the end of their enclosing loop. Co-authored-by: joshcarp <joshcarp@users.noreply.github.com> Co-authored-by: pgmitche <pgmitche@users.noreply.github.com>
camh-
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bytecode for a while statement is similar to that produced for
an
if
, except that the OpJump points to the start of thestatement and not the end. Break statements are also jumps to
the end of their enclosing loop.