Define and implement an array repetition operator #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for d89b908 |
camh-
commented
Apr 11, 2024
camh-
commented
Apr 11, 2024
juliaogris
approved these changes
Apr 11, 2024
|
All fixed and pushed. PTAL |
juliaogris
approved these changes
Apr 11, 2024
Rossiar
reviewed
Apr 11, 2024
|
do not merge label because I need to squash in the fixup commits before merging. I've forgotten to do that before, so this may help. |
Allow the `*` operator to be used on arrays with a number on the
right-hand side to repeat an array a number of times, producing an array
of the same type with repeated elements. This allows for creating arrays
of variable length without needing to write a loop.
e.g.
n := 4
a := [0] * n
will produce `[0 0 0 0]`.
There can be any number of elements in the array and they will all be
repeated. e.g. `[1 2] * 2` == `[1 2 1 2]`.
Update the spec to document this. Add an example to
`syntax_by_example.md`
Gen-command: make doc docs
Implement construction of arrays via array repetition, a `BinaryExpr` with an array value on the left and a number on the right. The result is the left array repeated the right number of times. Zero times results in an empty array. A non-integer value results in an error. Add test cases for all distinct cases - basic, zero, precedence, variable and error.
Implement construction of arrays via array repetition, similar to the evaluator. A new opcode, `OpArrayRepeat` is added for this operation which the compiler emits based on the types of the arguments to the `*` binary operator. Add tests for some basic cases and the error case. Disable some lint errors due to "complex" code. `vm.Run()` already disabled one, but now there's another. The test case is not really even complex. Stupid linters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the
array * numoperator to repeatarraynumnumber oftimes. This allows for easy initialisation of variable sized arrays
without needing to use a loop to do so.
Update the spec with a definition of the operator. Update
syntax_by_example.mdto give some basic examples.Implement this in the evaluator and the bytecode compiler/vm.
Issue: evylang/todo#101