eval: Error on non-integer index and slice expressions #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for 93cf098 |
Refactor slice and index normalization to work the same way that evaluator does it. In a follow up commit we will add checks for indices being integer values. This way it can be done in one place.
juliaogris
force-pushed
the
non-int-index-error
branch
from
ceba063
to
933e70f
Compare
Error on non-integer index and slice expressions as it doesn't make much sense to use it, e.g. in arr[1.1]. We are reusing the nice error message wording that was introduced in with the ErrBadRepetion. Fixes #317
juliaogris
force-pushed
the
non-int-index-error
branch
from
60c8bc4
to
93cf098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error on non-integer index and slice expressions as it doesn't make much sense
to use it, e.g. in arr[1.1]. We are reusing the nice error message wording
that was introduced in with the ErrBadRepetion. We have also copied the way
we do normalizeSlices indices from evaluator, basing it on normalizeIndex.
Fixes #317