learn: Update and refactor naming #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move question package to learn package as this seems the increasingly more suitable name, maybe we will even move it to the top-level /pkg directory. This change was prompted when renaming Model to QuesitonModel caused stutter linter warning some commits ahead.
Refactor question model to be explicitly called QuestionModel so we can free up the model model for an interface type.
Add learn.go file to package learn as entry point containing errors and package godocs. This is to follow the convention of using packagename.go as a starting point when reading the source code of a package.
juliaogris
changed the title
Refactor --unsealed-only into --ignore-sealed flag, which allows us to export unmarked and unverified sealed questions to HTML. Solution marking and answerkey additions are skipped if --ignore-sealed is set. This "ignore" seems to better reflect what's actually going on. While at it pull functional options in learn package out into their own file. We will add a few more and reuse them for the ExerciseModel soon.
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another carved-off refactoring PR in order to make
directory exporting and exercises modelling more reviewable
in a follow-up commit.
Refactors:
questionpackage tolearnModel toQuestionModel(in anticipation ofExerciseModel,UnitModel` etc.)--unsealed-onlyflag to--ignore-sealedlearn.gofile as entrypoint to the learn package with errors