-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
learn: Generate HTML with templates #380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
force-pushed
the
learn-catalog
branch
2 times, most recently
from
June 13, 2024 12:30
c0de0db
to
eba2d1b
Compare
Fix `clear` command for SVG output if it is invoked without parameter. Ensure that color is by default set to white.
Add Name() method to model to use in HTML title which is a preparatory step to a more configurable and templated approach to the HTML output.
Refactor testdata, again - sorry about the churn. We are preparing for only having HTML fragment output from the model an leaving full HTML doc export to export.go. For this we create a new top-level golden structure: - question[-with-marked] - exercise[-with-marked]
Generate learn resource HTML with templates so that we can optionally use embedded and linked CSS in preparation for deploying to learn.evy.dev.
camh-
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📗 LGTM
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate learn resource HTML with templates so that we can optionally use
embedded and linked CSS in preparation for deploying to learn.evy.dev.
In a follow up commit we should be ready to deploy to learn.evy.dev.
As usual start with a couple smaller preparatory, fix-up and refactor
commits.