e2e: Rename golden snapshots for docker platform #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename golden snapshots for docker platform from `linux` to `docker`. This is so that linux devs 🐣🐧 can have different local linux snapshots to what is generated via the playwright jammy docker image. In my case they seem to be different because I have locally the Fira Code font pre-installed. I have tried waiting for fonts to be loaded without luck 🤷♂.
juliaogris
force-pushed
the
e2e-docker-platform
branch
from
d14092e
to
b9d502c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename golden snapshots for docker platform from
linuxtodocker. This is sothat linux devs 🐣🐧 can have different local Linux snapshots to what is
generated via the playwright jammy docker image. In my case they seem to be
different because I have locally the Fira Code font pre-installed. I have tried
waiting for fonts to be loaded without luck 🤷♂.