play-site: Improve initialization concurrency #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
force-pushed
the
e2e-docker-platform
branch
from
d14092e
to
b9d502c
Compare
juliaogris
force-pushed
the
play-concurrent
branch
from
51db758
to
52d8679
Compare
camh-
reviewed
Aug 1, 2024
Improve initialization concurrency, so that we load sample.json, sample content in parallel to the large evy.wasm file. The difference can be observed in browser developer tools with network throttling enabled and watching the waterfall - instead of the previous: |--- evy.wasm -------------------------| |-- sample.json -| |-- welcome.evy -| we now have |--- evy.wasm -------------------------| |-- sample.json -| |-- welcome.evy -| This means that for any hash other than #welcome the editor contents are visible and syntax colored faster.
juliaogris
force-pushed
the
play-concurrent
branch
from
52d8679
to
67282a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve initialization concurrency, so that we load sample.json, sample content
in parallel to the large evy.wasm file. The difference can be observed in
browser developer tools with network throttling enabled and watching the
waterfall - instead of the previous:
we now have
This means that for any hash other than #welcome the editor contents are visible
and syntax colored faster.