Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump EEI to revision 3 #118

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Bump EEI to revision 3 #118

merged 1 commit into from
Jul 31, 2018

Conversation

axic
Copy link
Member

@axic axic commented Jul 30, 2018

The spec was changed in a backwards incompatible manner in #77 (commit 9dc5118)

@axic
Bump EEI to revision 3
b4e6a7a 
The spec was changed in a backwards incompatible manner in #77 (commit 9dc5118)
@axic axic mentioned this pull request Jul 30, 2018
Open
@lrettig
Copy link
Member

lrettig commented Jul 31, 2018

From @axic on Gitter (https://gitter.im/ewasm/internal?at=5b5f71af12f1be7137688ac5):

Currently the “EEI” spec is at “revision 2” and the “ECI” spec is at “revision 0”. We actually did break compatibility with #77 so proposed a fix with bumping to “revision 3” here: #118. Going forward I think the overall spec should have a revision, therefore “revision 3” or 4 applies to both EEI and ECI.

@axic axic merged commit 66e694c into master Jul 31, 2018
@axic axic deleted the eei-revision-3 branch July 31, 2018 15:13
@axic axic removed the in progress label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

@jakelang jakelang jakelang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axic @lrettig @chfast @jakelang