This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
Flip CALL result from EEI/POSIX convention to EVM convention #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
call-result
branch
4 times, most recently
from
c2b811c
to
75fcbd0
Compare
ehildenb
suggested changes
May 27, 2018
wasm/check_nonzero.wast
Outdated
| (func $check_nonzero | ||
| (param $a i32) | ||
| (result i32) | ||
|
|
There was a problem hiding this comment.
How about:
(return (i32.eqz (get_local $a)))
Instead of anything after this?
wasm/generateInterface.js
Outdated
| `(i64.store | ||
| (i32.add (get_global $sp) (i32.const ${spOffset * 32})) | ||
| (i64.extend_u/i32 | ||
| (call $check_nonzero ${call}) ;; flip CALL result from EVM convention to POSIX convention 0 -> 1 and 1,2,.. -> 2 |
There was a problem hiding this comment.
This comment does not make much sense to me, is it correct? Seems that we are doing 0 -> 1, 1,2,... -> 0 with $check_nonzero.
Merged
|
@ehildenb fixed, please review |
ehildenb
approved these changes
May 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #246. Part of #184.
Fixes the problem mentioned in #246 (comment)