New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: Seqera Platform CLI #2151
Conversation
Given that the tar step is from the workflow and not from the Seqera CLI itself, I think we should also cater for uncompressed files. Then can handle the custom stuff in the pipeline but it stays as general use as possible. |
The Seqera CLI natively dumps tar files. I was going to uncompress them in the same process that dumps the run info but if we don't have to then that would be a bonus. Supporting both would be great. The JSON files all have standard names so will be easy to scrape if we stage each run in its individual directory / archive. |
🚀 Deployed on https://mqc-pr-2151--multiqc.netlify.app |
Added support for both compressed and uncompressed dumps. Also added a barplot and parsing of the platform version. |
Maybe show a duration as a column, keep start + end dates but hide by default. |
👉🏻 Should specify the task status order + colours in the bar plot to match Tower:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise LGTM!
LGTM to me to merge, waiting on review from @drpatelh before hitting the button. |
Suggestion: Move CPU time and Cost columns up, alongside pipeline duration. These 3 columns are likely typically the most interesting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We know that cpuEfficiency and memoryEfficiency will always be percentages, so should format as such.
Co-authored-by: Robert Syme <rob.syme@gmail.com>
Co-authored-by: Robert Syme <rob.syme@gmail.com>
Great! Can we put the |
Done! (updated the comment above) |
Beautiful! Last main thing to add would be the Plots I outlined in #2151 (comment) Copied again below: Additional PlotsIt would be great to at least have bar plots for the more pertinent metrics so they can be dumped directly into presentations if required rather than having to generate them via another tool:
I have created issues on the Seqera CLI for things that would be good to add in the future. For now, I can try to find a workaround for using run names in the plots via a mapping file. |
We would have a separate plot for each metric which should be relatively simple? Definitely don't want to put those all in the same plot. |
Yes, exactly! One for each of the metrics I listed. The problem with having that in the table is you can't export it as a plot. Also, it will be nice to bring a larger focus on the core metrics if we have individual plots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome @vladsavelyev ! 🤩 Thank you! Some minor comments for consistency but otherwise LGTM! Be great to add in some other things in the future but this is definitely a good start.
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Looks great! 👏🏻 |
Parses
runs_*.tar.gz
dumps containing logs and stats from a Seqera Platform run. To be triggered in the https://github.com/seqeralabs/nf-aggregate workflow, or can parse the output oftw runs dump ... --output=runs_SmUkr43Nul49G.tar.gz
directly.Note that binary files by default are ignored by MultiQC, so you need to set
ignore_images: false
in the MultiQC config to make it parse the input tar-gz file. This can be done via the CLI:multiqc -m seqera_cli test_data/data/modules/seqera_cli -f -v --cl-config "ignore_images: false"