Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Status 26034-RISCV_Add_AVL_propagation_PASS_for_RVV_autovectorization-1 #449

Closed
github-actions bot opened this issue Oct 24, 2023 · 4 comments
Closed

Comments

@github-actions
Copy link

Precommit CI Run information

Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/6622136375

Patch information

Applied patches: 1 -> 1
Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=26034
Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20231024033200.224558-1-juzhe.zhong@rivai.ai/

Notes

Testsuite checks are in beta testing stages. Results are unstable and may be inaccurate.

@github-actions
Copy link
Author

github-actions bot commented Oct 24, 2023

Lint Status

The following issues have been found with 26034-RISCV_Add_AVL_propagation_PASS_for_RVV_autovectorization-1 using gcc's ./contrib/check_GNU_style.py.
Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch.
If any of these warnings seem like false-positives that could be guarded against please contact me: patchworks-ci@rivosinc.com.

=== ERROR type #1: braces should be on a separate line (1 error(s)) ===
gcc/config/riscv/riscv-avlprop.cc:104:77:  pass_avlprop (gcc::context *ctxt) : rtl_opt_pass (pass_data_avlprop, ctxt) {}

=== ERROR type #2: dot, space, space, end of comment (12 error(s)) ===
gcc/config/riscv/riscv-avlprop.cc:90:20:  RTL_PASS,	 /* type */
gcc/config/riscv/riscv-avlprop.cc:91:21:  "avlprop",	 /* name */
gcc/config/riscv/riscv-avlprop.cc:92:33:  OPTGROUP_NONE, /* optinfo_flags */
gcc/config/riscv/riscv-avlprop.cc:93:20:  TV_NONE,	 /* tv_id */
gcc/config/riscv/riscv-avlprop.cc:94:29:  0,		 /* properties_required */
gcc/config/riscv/riscv-avlprop.cc:95:29:  0,		 /* properties_provided */
gcc/config/riscv/riscv-avlprop.cc:96:30:  0,		 /* properties_destroyed */
gcc/config/riscv/riscv-avlprop.cc:97:26:  0,		 /* todo_flags_start */
gcc/config/riscv/riscv-avlprop.cc:98:27:  0,		 /* todo_flags_finish */
gcc/config/riscv/riscv-avlprop.cc:282:77:  /* Go through all the instructions looking for AVL that we could propagate.█*/
gcc/config/riscv/riscv-v.cc:4451:77:     to emit vsetvl. We pick up the default value according to prefer policy.█*/
gcc/config/riscv/riscv-v.cc:4497:43:   all RVV instructions that have VTYPE OP.█*/

=== ERROR type #3: dot, space, space, new sentence (7 error(s)) ===
gcc/config/riscv/riscv-avlprop.cc:26:49:       there will become even harder to maintain.█A straight forward
gcc/config/riscv/riscv-avlprop.cc:167:34:       arithmetic operations (e.d.█DIV), then do the whole vector register
gcc/config/riscv/riscv-avlprop.cc:173:65:   generates the VLMAX instruction due to missed LEN information.█The later
gcc/config/riscv/riscv-avlprop.cc:198:18:	     instruction.█It should be totally enough for vectorized codes since
gcc/config/riscv/riscv-v.cc:4451:20:     to emit vsetvl.█We pick up the default value according to prefer policy. */
gcc/config/riscv/riscv-v.cc:4488:38:/* Helper function to get SEW operand.█We always have SEW value for
gcc/config/riscv/riscv-v.cc:4496:40:/* Helper function to get VLMUL operand.█We always have VLMUL value for

=== ERROR type #4: lines should not exceed 80 characters (1 error(s)) ===
gcc/config.gcc:547:80:        extra_objs="${extra_objs} riscv-v.o riscv-vsetvl.o riscv-vector-costs.o riscv-avlprop.o"

=== ERROR type #5: there should be exactly one space between function name and parenthesis (1 error(s)) ===
gcc/config/riscv/riscv-avlprop.cc:9:50:the Free Software Foundation; either version 3, or(at your option)

=== ERROR type #6: trailing whitespace (1 error(s)) ===
gcc/config/riscv/t-riscv:74:65:  $(TARGET_H) tree-pass.h df.h rtl-ssa.h cfgcleanup.h insn-attr.h█

Additional information

@github-actions
Copy link
Author

github-actions bot commented Oct 24, 2023

Apply Status

Target Status
Baseline hash: gcc-mirror/gcc@1acd457 Failed
Tip of tree hash: gcc-mirror/gcc@7b2984a Applied

Notes

Failed to apply to the post-commit baseline. This can happen
if your commit requires a recently-commited patch in order to apply.
The pre-commit CI will only perform a build since it doesn't know what
dejagnu testsuite failures are expected on the tip-of-tree.

If you would like us to re-run this patch once the baseline reaches a
different hash, please email us at patchworks-ci@rivosinc.com with a link
to your patch.

Additional information

@github-actions
Copy link
Author

github-actions bot commented Oct 24, 2023

Build GCC Status

Target Status
linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-non-multilib Success
newlib-rv64gc-lp64d-multilib Success
linux-rv64gc_zba_zbb_zbc_zbs-lp64d-non-multilib Success
linux-rv64gcv-lp64d-multilib Success

Notes

Patch(es) were applied to the baseline hash gcc-mirror/gcc@1acd457. If this patch commit depends on or conflicts with a recently committed patch, then these results may be outdated.

Additional information

@github-actions
Copy link
Author

Testsuite Status (Beta - Ignore Results)

Testsuite tests were skipped. Patch did not apply to baseline hash gcc-mirror/gcc@1acd457. No comparison applicable.

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant