Fixed deprectation warning from using ruby 2.7.1 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aybe ** should be added to the call` warnings when using ruby 2.7
|
@exAspArk With Ruby v3.0 out now, I think this pull request could use some attention? I'm seeing this warning fail on builds now. |
|
👋 It would be great if we could get this out in a gem release. 🙏 |
|
Thanks a lot! 💛 And sorry for the delayed response. I'll try to adjust the TravisCI config to add the latest Ruby versions and create a new release. |
|
I released these changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Ruby 2.7.1, the gem triggers a
Using the last argument as keyword parameters is deprecated; maybe ** should be added to the calldeprecation warning. This PR resolves the warning. The specs complete without error under Ruby 2.6.4 and 2.7.1