feat(esl-mixin-element): v2.0.0 improvements #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nElement` Extend tests for `ESLMixinElement` initialization
…improvements # Conflicts: # src/modules/esl-mixin-element/ui/esl-mixin-element.ts
…cted visibility modifier `getAll` public utility method
…ionality by unit tests
…ally by mixin manager
ala-n
requested review from
a team,
dshovchko,
julia-murashko and
abarmina
and removed request for
a team
fshovchko
approved these changes
May 12, 2023
NastaLeo
approved these changes
May 15, 2023
HenadzV
approved these changes
May 15, 2023
yadamskaya
approved these changes
May 15, 2023
dshovchko
approved these changes
May 15, 2023
Natalie-Smirnova
approved these changes
May 15, 2023
Co-authored-by: Yuliya Adamska <48826082+yadamskaya@users.noreply.github.com> Co-authored-by: Anastasiya Lesun <72765981+NastaLeo@users.noreply.github.com>
|
Code Climate has analyzed commit dd39ebb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.0% (0.5% change). View more on Code Climate. |
abarmina
approved these changes
May 15, 2023
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLMixinELementAPI