params_lookup and puppet 3

[janorn]

When using these modules on Puppet ver 3 I get these errors:

err: Could not retrieve catalog from remote server: Error 400 on SERVER: custom functions must be called with a single array that contains the arguments. For example, function_example([1]) instead of function_example(1) at /etc/puppet/modules/resolver/manifests/init.pp:148 on node puppetclient

[alvagante]

I'm not able to reproduce the error (https://travis-ci.org/example42/puppet-dhcpd)
Can you give more details on the environment and be sure to have the modules updated (especially the puppi one)?

[janorn]

I have two environments. Both Solaris.

First it works in this environment.
Master Solaris 11 Puppet 2.7.21
Client Solaris 10 Puppet 2.7.20

The problematic setup is a clone of the master which has been upgraded.
Master Solaris 11 Puppet 3.1.1
Client Solaris 10 Puppet 2.7.20

Modules:
puppi last commit "Date: Wed Apr 10 03:30:13 2013 -0700"
resolver last commit "Date: Sat Mar 9 00:09:50 2013 +0100"

[janorn]

Have you been able to reproduce this?

[alvagante]

Sorry, no.
I've not an easily testable Solaris box at disposal (if you know an url or can provide a Solaris10/11 Vagrant base box that would help a lot, having Solaris boxes here https://github.com/example42/puppet-playground would help a lot the support for Solaris ).
What I can say is that the problem seems related to the params_lookup function (provided by the Puppi module and used in all example42 modules for any parameter assed to the main class) and that a somehow related issue (not using arrays inside functions) was fixed on Puppi when Puppet 3 was released (so is surely covered by your puppi version).

I tested on a Puppet 3.1.1 (on Linux) without problems.
Just a question: do you have the same problem with both client and server at 3.1.1?

The issue is potentially serious anyway, because params_lookup is at the core or Example42 modules, so this has to be investigaed.

Can you try some changes on the first line of the resolver where params_lokup is used and see if the error "shitfs" to the following line:
Instead of:

  $dns_domain          = params_lookup( 'dns_domain' , 'global' ),

try:

  $dns_domain          = params_lookup( ['dns_domain' , 'global'] ),

or

  $dns_domain          = params_lookup( ['dns_domain'] , ['global'] ),

and let me know if:

err: Could not retrieve catalog from remote server: Error 400 on SERVER: custom functions must be called with a single array that contains the arguments. For example, function_example([1]) instead of function_example(1) at /etc/puppet/modules/resolver/manifests/init.pp:148 on node puppetclient

becomes:

err: Could not retrieve catalog from remote server: Error 400 on SERVER: custom functions must be called with a single array that contains the arguments. For example, function_example([1]) instead of function_example(1) at /etc/puppet/modules/resolver/manifests/init.pp:149 on node puppetclient

[janorn]

I will look into this next week.

[janorn]

I can not reproduce this anymore either. Strange.

[alvagante]

Well, suppose (and hope) I can close the issue