puppet::server::passenger requires apache

[bmcclure]

puppet::server::passenger requires apache, while it actually works perfectly fine on nginx as well.

I am trying to use this module to deploy puppet and puppetmaster configuration on all of my servers, but in order to get the right service settings I need to set 'passenger' to true. However, I don't want it to include or install anything for Apache.

Is there an easy way for me to accomplish this just by creating a my_puppet class to include? I planned to create a my_puppet::passenger class which configures nginx and passenger properly, but it seems like I still need some way to set puppet::passenger to true to prevent it from auto-starting and monitoring the service.

[bmcclure]

It seems like maybe just an extra parameter on the puppet module like $passenger_apache, which could default to true to retain the current behavior, would solve this issue. You could then just wrap the two include statements in puppet::server::passenger in a conditional, and if using nginx or another server type it would be up to the class defined in $my_class to configure the passenger server itself.

[bmcclure]

Attempting to solve this in my own fork, I still need to do more testing, but will make a pull request when it's ready. In the meantime, here's my approach so far:

VolantisOps@98cd658

[bmcclure]

This can be closed now that the mentioned pull request has been merged. Thanks for doing that!