Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally check keystore and truststore file when SASL_SSL protocol used #55

Closed
morazow opened this issue Oct 5, 2021 · 2 comments · Fixed by #57
Closed

Optionally check keystore and truststore file when SASL_SSL protocol used #55

morazow opened this issue Oct 5, 2021 · 2 comments · Fixed by #57
Labels
refactoring Code improvement without behavior change

Comments

@morazow
Copy link
Contributor

morazow commented Oct 5, 2021

Situation

At the moment, we require keystore and truststore JKS files stored in BucketFS bucket when using security protocols SSL
and SASL_SSL.

For SASL_SSL this should be optional since JAAS configuration can be also used.

Acceptance Criteria

  • Skips keystore and truststore location checks when using SASL_SSL protocol.
  • Sets locations files if they are provided.
@millin
Copy link
Contributor

millin commented Oct 15, 2021

Hello @morazow!
There seems to be some mistake.
From now when SECURITY_PROTOCOL = 'SASL_SSL' keystore and truststore files are ignored and not passed to kafka parameters.

@morazow
Copy link
Contributor Author

morazow commented Oct 15, 2021

Hey @millin,

Thanks a lot! Indeed we forgot to set the location files after validation.

I am fixing and releasing a new version.

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
2 participants