Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boundElementIds when arrows bound to elements are deleted #5077

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Apr 21, 2022

fixes #5008

@vercel
Copy link

vercel bot commented Apr 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
excalidraw ✅ Ready (Inspect) Visit Preview Apr 21, 2022 at 1:20PM (UTC)
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Apr 21, 2022 at 1:20PM (UTC)

Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed incorrect type assertions (we shouldn't be asserting in the first place) which resulted in adding attributes on element types they don't belong to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a bound arrow will leave a phantom reference in boundElements[] of the target
2 participants