Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack config exclude statement to system agnostic #6857

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

zsviczian
Copy link
Collaborator

@zsviczian zsviczian commented Aug 5, 2023

I modified the exclude statement in webpack.config to work on Windows.

The rest of the changes are simply to align the order of declarations between .prod.js and .dev.js. These add nothing to functionality and only serve my OCD.

@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Aug 5, 2023 7:33am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Aug 5, 2023 7:33am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 5, 2023 7:33am

@zsviczian zsviczian requested a review from ad1992 August 5, 2023 07:34
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 72.57% / 70% 39795 / 54835
🟢 Statements 72.57% / 70% 39795 / 54835
🟢 Functions 68.28% / 68% 1279 / 1873
🟢 Branches 79.94% / 70% 4836 / 6049
File CoverageNo changed files found.
Generated in workflow #56

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 279.86 KB (0%) 5.6 s (0%) 895 ms (+13.73% 🔺) 6.5 s
dist/excalidraw-assets/locales 261.47 KB (0%) 5.3 s (0%) 476 ms (+35.57% 🔺) 5.8 s
dist/excalidraw-assets/vendor*.js 28.06 KB (0%) 562 ms (0%) 310 ms (+48.52% 🔺) 871 ms

@dwelle
Copy link
Member

dwelle commented Aug 5, 2023

Thanks!

@dwelle dwelle merged commit e7983bc into master Aug 5, 2023
7 checks passed
@dwelle dwelle deleted the zsviczian-webpack-windows branch August 5, 2023 09:49
alswl pushed a commit to alswl/excalidraw that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants