"google/recaptcha" library | PhpUnit | Symfony recipes | Travis-CI | Bugfix

[D3strukt0r]

Here I tried to fix following stuff:

1. "google/recaptcha" library
   Instead of checking the reCaptcha on our its own, it will use the already given library from google.
   What was done is running $ composer require google/recaptcha and then accordingly change the code in src/Validator/Constraints/IsTrueValidator

However, by doing this the proxy functionality is gone. If this is no problem, the README.md and src/DependencyInjection/Configuration.php file have to be configured!

2. PhpUnit
   Just a small change. In composer it now searches for the newest (and with php compatible) version of phpUnit just by using "phpunit/phpunit": "^5 || ^6 || ^7". What had to be changed were the files "extended" from \PHPUnit_Framework_TestCase to TestCase

3. Symfony recipes
   When installing this bundle without a config file following error is generated:

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!  In ArrayNode.php line 230:
!!                                                                             
!!    The child node "public_key" at path "ewz_recaptcha" must be configured.  
!!                                                                             
!!
!!
Script @auto-scripts was called via post-update-cmd

This can be prevented if the owner(!) creates a pull request for the recipes repo (https://github.com/symfony/recipes-contrib). Please read requirements. For example, one of them is that symfony/security cannot be "required"

I suggest following:
manifest.json

{
    "bundles": {
        "EWZ\\Bundle\\RecaptchaBundle\\EWZRecaptchaBundle": ["all"]
    },
    "copy-from-recipe": {
        "config/": "%CONFIG_DIR%/"
    },
    "env": {
        "EWZ_RECAPTCHA_PUBLIC_KEY": "needed",
        "EWZ_RECAPTCHA_PRIVATE_KEY": "needed"
    }
}

post-install.txt

<bg=blue;fg=white> Next for EWZRecaptchaBundle</>
    * <fg=blue>Insert</> sensitive values in your environment values

config/packages/ewz_recaptcha.yaml

ewz_recaptcha:
    public_key:  '%env(EWZ_RECAPTCHA_PUBLIC_KEY)%'
    private_key: '%env(EWZ_RECAPTCHA_PRIVATE_KEY)%'

4. .travis.yml
   Also here was done just a minor fix. Because previously not the right Symfony versions were tested

5. Bugfix
   Personally I was never able to use this package for the following problem:

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!  In ParameterBag.php line 100:
!!                                                                       
!!    You have requested a non-existent parameter "templating.engines".  
!!                                                                       
!!
!!
Script @auto-scripts was called via post-update-cmd

The problem lies in src/DependencyInjection/EWZRecapchtaExtension.php
I couldn't find a better solution than following:

$templatingEngines = $container->hasParameter('templating.engines')
            ? $container->getParameter('templating.engines')
            : array('twig');

So this should be definitely reviewed!

6. php version compatibility reduced to >=5.3.9
As Symfony 2.8 requires min php 5.3.9 it would make sense to do the same for this project. The only features that can't be used is short array creation [], instead array() has to be used and the constant ::class has to be changed with the whole namespace\class. PhpUnit ->createMock started on PhpUnit 5 (php 5.6+). Maybe use https://github.com/mockery/mockery ?

[excelwebzone]

@D3strukt0r Thanks for creating the repo. Since the proxy is required by other users, I suggest changing the code to support both options. Also, don't modify the config settings only the README, PHP and TWIG files, unless something fails when running test or required for your changes. Thanks again.

[D3strukt0r]

To support proxy I need to create a copy of ReCaptcha\RequestMethod\Post (https://github.com/google/recaptcha/blob/master/src/ReCaptcha/RequestMethod/Post.php) in which I could put the code for it, question is; where do you want me to put the file @excelwebzone ? Maybe ./Extension/ReCaptcha/RequestMethod/ProxyPost.php?

[D3strukt0r]

So, basically I'm finished. Everything should work just like before