Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 3.0 support #77

Merged
merged 6 commits into from
Dec 19, 2015
Merged

Conversation

jbgomond
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #76
License MIT

I've added Symfony 3.0 support and PSR-4 to the bundle.

Notice : I've restricted this to Symfony 3.0 but it is also compatible with Symfony 2.8 (juste have to modify the composer.json file).

excelwebzone added a commit that referenced this pull request Dec 19, 2015
@excelwebzone excelwebzone merged commit 9ef5b5a into excelwebzone:master Dec 19, 2015
excelwebzone added a commit that referenced this pull request Dec 19, 2015
@QuingKhaos
Copy link
Contributor

QuingKhaos commented Aug 23, 2016

@MJBGO Btw. why was the class renamed to EWZRecaptchaType? This was IMHO a huge BC break, especially as this got released in a bugfix version.

RecaptchaType::class would be never a problem, because it's still namespaced..

@QuingKhaos
Copy link
Contributor

And I don't understand what a change from XML to YAML for services has to do in a Symfony 3 support PR? That's annoying..

@JarJak
Copy link

JarJak commented Oct 19, 2016

This one destroyed my app... If you do BC breaks, please follow semantic versioning. Part of my composer.json:
"excelwebzone/recaptcha-bundle": "^1.4",
in Symfony 2.8 I had form field type defined as 'ewz_recaptcha' which does not exists so I had exceptions: "Could not load type "ewz_recaptcha". After changing to EWZRecaptchaType::class everything works fine.

@jbgomond
Copy link
Contributor Author

jbgomond commented Oct 21, 2016

Not really my fault, it was written BC breaks from the beginning ...

But I agree, creating another big version for that was the way to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants