Display which paths led to "Illegal BMS Songs" error #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chazoshtare
force-pushed
the
feature/display-illegal-songs-paths
branch
2 times, most recently
from
c19b2c7
to
cd7a909
Compare
Chazoshtare
force-pushed
the
feature/display-illegal-songs-paths
branch
from
cd7a909
to
f83deb1
Compare
Chazoshtare
force-pushed
the
feature/display-illegal-songs-paths
branch
from
f83deb1
to
9b98ae7
Compare
Chazoshtare
force-pushed
the
feature/display-illegal-songs-paths
branch
from
9b98ae7
to
e7ec430
Compare
Chazoshtare
force-pushed
the
feature/display-illegal-songs-paths
branch
from
e7ec430
to
b68a2bc
Compare
Chazoshtare
force-pushed
the
feature/display-illegal-songs-paths
branch
from
b68a2bc
to
3517fc0
Compare
…unused checks Displayed error paths are capped to 30 lines to limit potential big dialog window size. More will be shown once the user deletes the folders.
Chazoshtare
force-pushed
the
feature/display-illegal-songs-paths
branch
from
3517fc0
to
35bce16
Compare
|
any updates on this? I wish to delete illegal BMS from my collection - output to a txt file would be nice so i can identify the songs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a user would have any illegal BMS files or the detection system would react on any false positives, there is no way to tell which BMS files cause the error.
This PR adds paths to the error message displayed, so it's easier for the user to identify which song packs should be deleted or included in an issue about false positives.
The paths displayed are capped at 30 lines to limit the dialog window potential size.
Detected charts are not stored in a variable in MainLoader anymore, and two unreachable checks were also removed - they cannot happen if the application won't start anyway.
Part of this PR just removes unneeded whitespace, but it's split in separate commits. Main commit that represents the main logic change can be viewed here: 3517fc0