Minor code optimizations #634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think large pull requests are a good idea, they should be broken up into small changes. |
Chazoshtare
force-pushed
the
feature/minor-optimizations
branch
from
9281b85
to
bda842e
Compare
|
In that case I moved the biggest refactoring change to a different PR, I'll just leave smaller ones here. |
Chazoshtare
force-pushed
the
feature/minor-optimizations
branch
2 times, most recently
from
354bdf8
to
d387dbd
Compare
Chazoshtare
force-pushed
the
feature/minor-optimizations
branch
from
d387dbd
to
f9bf40c
Compare
Chazoshtare
force-pushed
the
feature/minor-optimizations
branch
from
f9bf40c
to
437f932
Compare
Chazoshtare
force-pushed
the
feature/minor-optimizations
branch
from
437f932
to
745ae46
Compare
Chazoshtare
force-pushed
the
feature/minor-optimizations
branch
from
745ae46
to
30bb962
Compare
Chazoshtare
force-pushed
the
feature/minor-optimizations
branch
from
e76f59a
to
e4b51f8
Compare
With current JDK optimizations, in vast majority of usecases it's better to pass a zero-sized array, as the operation is going to have at most the same, and in some cases better performance than with a pre-sized array. It also results in a shorter declaration.
Chazoshtare
force-pushed
the
feature/minor-optimizations
branch
from
e4b51f8
to
82d245d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple minor optimizations applied in this PR, either relevant to code performance or readability, explained in detail in commit messages when applicable.