Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove puts from delivery method base #352

Closed
wants to merge 1 commit into from
Closed

Conversation

marostr
Copy link

@marostr marostr commented Dec 1, 2023

Pull Request

Summary:
Removal of a lonely puts. It annoyed me.

  • [ x ] Code follows the project's coding standards
  • [ x ] All existing tests pass

@excid3 excid3 closed this Jan 15, 2024
@marostr
Copy link
Author

marostr commented Feb 9, 2024

@excid3 why?

I'm getting this puts on my rspec output, like

...........400 Bad Request
{"code": 21212, "message": "The 'From' number 15005550001 is not a valid phone number, shortcode, or alphanumeric sender ID.", "more_info": "https://www.twilio.com/docs/errors/21212", "status": 400}
..................................................................................................F...............

@excid3
Copy link
Owner

excid3 commented Feb 9, 2024

We're no longer developing on Noticed 1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants