Returning the result of the symbol evaluation for ios format #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary:
Making sure to return after evaluating an iOS symbolized format method.
Related Issue:
Description:
Right now, the
Noticed::DeliveryMethods::Ios#format_notification
method is setup to handle a proc, symbol or message. When the symbol version of the format method is used, it evaluates the symbol using send and then callsnotification.instance_exec
with the result from theevent.send
call. This causes an error in execution.Testing:
This was tested to work on my local machine against our codebase.
Screenshots (if applicable):
Checklist:
Additional Notes: