Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning the result of the symbol evaluation for ios format #390

Merged
merged 4 commits into from
Jan 27, 2024

Conversation

avanrielly
Copy link
Contributor

@avanrielly avanrielly commented Jan 26, 2024

Pull Request

Summary:
Making sure to return after evaluating an iOS symbolized format method.

Related Issue:

Description:
Right now, the Noticed::DeliveryMethods::Ios#format_notification method is setup to handle a proc, symbol or message. When the symbol version of the format method is used, it evaluates the symbol using send and then calls notification.instance_exec with the result from the event.send call. This causes an error in execution.

Testing:
This was tested to work on my local machine against our codebase.

Screenshots (if applicable):

Checklist:

  • Code follows the project's coding standards
  • Tests have been added or updated to cover the changes
  • Documentation has been updated (if applicable)
  • All existing tests pass
  • Conforms to the contributing guidelines

Additional Notes:

@excid3
Copy link
Owner

excid3 commented Jan 26, 2024

Ah yes, I missed this when reviewing!

cc @phil-6

@excid3 excid3 added the bug Something isn't working label Jan 26, 2024
@excid3 excid3 self-assigned this Jan 26, 2024
@excid3 excid3 merged commit 8a85d5b into excid3:main Jan 27, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants