Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! :)
The
autoload
calls in this file are unnecessary, because therequire
calls above already define those constants.Since I was on it, I refactored the way I normally write a file like this. Let me explain:
simple_calendar.rb
, I find ordered that it owns the creation of theSimpleCalendar
module. Then, descendants reopen. They can also use constant paths likeSimpleCalendar::ViewHelpers
in the definition of child classes and modules if they so wish, because they can rely on the parent module being already defined upwards. (This is only a consequence, not the motivation.)$LOAD_PATH
lookups by usingrequire_relative
.However, these points are kind of personal style, if you prefer something else please just tell me :).