-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
garage_wo_car_flag: add parking places from "other" #50
Comments
Checked on a partial dataset (88K) There is a vehicle in declaration: |
Well, the question here is should we count in vehicles that aren't owned by
declarant or family. Current implementation doesn't count them. Let me know
if you'd like to change that
…On Thu, Apr 23, 2020 at 9:57 PM Olga Makarova ***@***.***> wrote:
Checked on a partial dataset (88K)
~60 mismatches, all True, but should be False
There is a vehicle in declaration:
nacp_00d0b1ec-db68-4b74-b480-94f777d2b1fb
nacp_00dab510-cefe-4f5b-bdcf-2c1da9e9292c
nacp_9901c610-6c3d-419e-bfba-931b291768df
nacp_99042d99-0e63-488a-96d0-f837a3850f00
nacp_9929ee56-3e0a-4a08-9e65-d7b2ad69d4a0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABAA4VGFY43FLGFMTTINHLROCFQBANCNFSM4MPKRLSA>
.
|
Right, I have checked considering ownership. Now 35 mismatches, all True, but should be False:
|
Now flag is raised if:
Suggestion: besides garages, add also "other" estate objects, which have in their description something about parking place or place for a car. Suggested patterns, based on the analysis of the data are:
The text was updated successfully, but these errors were encountered: