Feature/autoprefixer #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Normalise line endings for comparisons - Remove missing js folder reference
- Added basic support for autoprefixing with CSS intermediates - Added sourcemap support for SCSS roots - Adjusted test files to support autoprefixing - Adjusted help text - Amended config file
|
Thanks so much for this contribution, @elken! |
|
Happy to help out! Use it often at work, good to give back 😁
…On 21 Sep 2020, 11:07, at 11:07, "Stefan Lörwald" ***@***.***> wrote:
Thanks so much for this contribution, @elken!
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#11 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1 and includes changes for #10.
Added support for autoprefixing as an optional step, which comes right after SCSS and before any CSS intermediary files.
Attempts to use SCSS sourcemap in the generation, although I didn't add the ability to output said files. I think there might be some value in adding some kind of "intermediary file" tracking to
Compilersbut it's out of scope of this PR.I've also taken the (possibliy opinionated) choice to default autoprefixing in all the tests, happy to add some cases without but that would require adjusting the file structure you have in place slightly.