Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: update linting #551

Merged
merged 5 commits into from
Oct 13, 2023
Merged

MAINT: update linting #551

merged 5 commits into from
Oct 13, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 13, 2023 •
edited
Loading

This PR replaces flake8 with ruff, updates some linting defaults, and fixes mypy.

@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
myst_nb/core/config.py 79.23% <100.00%> (ø)
myst_nb/core/render.py 85.28% <100.00%> (ø)
myst_nb/docutils_.py 73.68% <100.00%> (ø)
myst_nb/sphinx_.py 89.78% <100.00%> (ø)
myst_nb/sphinx_ext.py 91.07% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@agoose77 agoose77 enabled auto-merge (squash) October 13, 2023 11:07
choldgraf
choldgraf approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - I'm not too familiar with ruff but if you think it has a clear benefit over flake8 then let's go for it

@agoose77 agoose77 merged commit d59ff0b into master Oct 13, 2023
21 checks passed
@agoose77
Copy link
Collaborator Author

agoose77 commented Oct 13, 2023 •
edited
Loading

We're using ruff in scikit-hep, and Scientific Python: https://learn.scientific-python.org/development/guides/style/

I endorse it for being a lot faster (it's written in Rust)!

@bsipocz bsipocz deleted the agoose77/chore-update-linting branch September 25, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @choldgraf