👌 IMPROVE: Use correct renderer for state.inline_text
#466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `state.inline_text` (used by some directives) always parsed text with the `DocutilsRenderer`. Now it will correctly use the `SphinxRenderer`, when parsing with sphinx, allowing for cross-document references to be handled.
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01%
==========================================
Files 16 16
Lines 1991 1990 -1
==========================================
- Hits 1798 1797 -1
Misses 193 193
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
state.inline_text()(used by some directives)always parsed text with the
DocutilsRenderer.Now it will correctly use the
SphinxRenderer,when parsing with sphinx,
allowing for cross-document references to be handled.