-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Use Sphinx Design instead of Sphinx Panels #1442
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1442 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 7 7
Lines 687 687
=======================================
Hits 627 627
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Made some more progress replacing all of the sphinx-panels usage with sphinx-design, and also updated some of our front page elements to be inspired by myst-nb. Hopefully getting close... |
@mmcky or @AakashGfude do you have any idea what's going on with this latex error? It seems related to colors somehow?
|
@choldgraf that is a new one. It looks like |
this library uses https://github.com/missinglinkelectronics/sphinxcontrib-svg2pdfconverter |
I don't understand why that would have changed with this PR though, did Sphinx release a new patch that introduced a breaking change or something? From the error it seems like it is the jupyter-book logo causing it:
|
So there is no new images being generated in this PR? I will try and take a closer look at the diff today and see what might be driving this switch to |
@choldgraf so this error is coming from a file called OK it looks like that badge is malformed and color is missing the
but I don't see this anywhere on the @choldgraf at a dead end debugging this as I just found out |
Ah @mmcky excellent investigation - your intuition is correct, it was the GitHub badge that was causing the problem, so I've modified this PR to only include those on I think that things look ready to go, so I'll mark this as ready and see if there are any QA suggestions or improvements to make before we merge. |
OK I'm gonna merge this one in, the docs seem OK, tests are passing, and the front page looks a little bit nicer, so I declare iterative improvement accomplished :-D We might need to spot check some docs improvement here or there if we missed something, so please keep an eye out for anything we missed. |
This swaps out Sphinx Design for Sphinx Panels, since Sphinx Design is the package that will be maintained moving forward. It updates some of our documentation to use the new Sphinx Design syntax and examples.
To do