Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for per notebook/cell execution timeout settings #39

Open
chrisjsewell opened this issue Mar 13, 2020 · 10 comments
Open

Allow for per notebook/cell execution timeout settings #39

chrisjsewell opened this issue Mar 13, 2020 · 10 comments
Labels
enhancement New feature or request

Comments

@chrisjsewell
Copy link
Member

chrisjsewell commented Mar 13, 2020

Stored in metadata, that is implemented by the executor

Also relates to #5

@chrisjsewell chrisjsewell added the enhancement New feature or request label Mar 13, 2020
@choldgraf
Copy link
Member

Hmm - I suspect that the nbformat issue will take some time to resolve, so I wonder if we should just go with @AakashGfude 's proposed metadata spec, and if Jupyter adopts an "official" one then we can support that as well. Some folks have reported this bug in Jupyter Book, so I think we should just go with a short-term solution. WDYT?

@chrisjsewell
Copy link
Member Author

Yeh go for it. Just make sure that an issue is still open for the "long-term" solution, so we don't forget

@choldgraf
Copy link
Member

cc @AakashGfude , in case you have a moment to wrap up your PR on this one (see above comment for context)

@AakashGfude
Copy link
Member

ooh. cool. I will wrap this up as soon as I can.

@choldgraf
Copy link
Member

@AakashGfude awesome, thanks...we've had like 3 bug reports opened about this particular issue already 😆

@AakashGfude
Copy link
Member

oops. sorry I missed this one. The PRs in Myst-NB and jupyter-cache were ready to be merged from my side. Additionally, I will try and add a test for this in Myst-NB.

@AakashGfude
Copy link
Member

@choldgraf have added test-cases. Note that the Tests in Myst-NB will fail, until the PR in jupyter-cache is merged.
If you have time, will you be able to add the necessary additions for execution_timeout in jupyter-book? Else I can do it some time during the weekend.

@choldgraf
Copy link
Member

@AakashGfude for sure, I'll figure out how to get it into jupyter book

@poldrack
Copy link

any update on this? I'm running into the same timeout issue as #613

@choldgraf
Copy link
Member

I believe that if you add notebook-level metadata to a page then it should work w/ the latest version of jupyter-cache: https://jupyter-cache.readthedocs.io/en/latest/using/api.html?highlight=timeout#timeout

however we have not yet documented this in Jupyter Book! @poldrack if this works for you, can you let us know and we can try to add docs for it in JB?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants