-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for per notebook/cell execution timeout settings #39
Comments
Hmm - I suspect that the nbformat issue will take some time to resolve, so I wonder if we should just go with @AakashGfude 's proposed metadata spec, and if Jupyter adopts an "official" one then we can support that as well. Some folks have reported this bug in Jupyter Book, so I think we should just go with a short-term solution. WDYT? |
Yeh go for it. Just make sure that an issue is still open for the "long-term" solution, so we don't forget |
cc @AakashGfude , in case you have a moment to wrap up your PR on this one (see above comment for context) |
ooh. cool. I will wrap this up as soon as I can. |
@AakashGfude awesome, thanks...we've had like 3 bug reports opened about this particular issue already 😆 |
oops. sorry I missed this one. The PRs in Myst-NB and jupyter-cache were ready to be merged from my side. Additionally, I will try and add a test for this in Myst-NB. |
@choldgraf have added test-cases. Note that the Tests in Myst-NB will fail, until the PR in jupyter-cache is merged. |
@AakashGfude for sure, I'll figure out how to get it into jupyter book |
any update on this? I'm running into the same timeout issue as #613 |
I believe that if you add notebook-level metadata to a page then it should work w/ the latest version of jupyter-cache: https://jupyter-cache.readthedocs.io/en/latest/using/api.html?highlight=timeout#timeout however we have not yet documented this in Jupyter Book! @poldrack if this works for you, can you let us know and we can try to add docs for it in JB? |
Stored in metadata, that is implemented by the executor
Also relates to #5
The text was updated successfully, but these errors were encountered: