Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: Clarify docs regarding security configuration #296

Merged
merged 3 commits into from
Jul 5, 2023
Merged

📚 DOCS: Clarify docs regarding security configuration #296

merged 3 commits into from
Jul 5, 2023

Conversation

djramones
Copy link
Contributor

Fixes #295.

This includes a small edit to the project README.
@welcome
Copy link

welcome bot commented Jul 3, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (14cca38) 95.17% compared to head (b2d5711) 95.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          64       64           
  Lines        3437     3437           
=======================================
  Hits         3271     3271           
  Misses        166      166           
Flag Coverage Δ
pytests 95.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change; "does not care about security" felt a bit harsh 😅

docs/security.md Outdated Show resolved Hide resolved
djramones and others added 2 commits July 5, 2023 20:18
Co-authored-by: Chris Sewell <chrisj_sewell@hotmail.com>
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@chrisjsewell chrisjsewell merged commit 3613e80 into executablebooks:master Jul 5, 2023
@welcome
Copy link

welcome bot commented Jul 5, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@djramones djramones deleted the safety-config-docs branch July 6, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default configuration is unsafe, contrary to documentation
2 participants