🎨 Fix line break and space rendering and align directive margin for code blocks #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
This looks great, I will have a closer test today locally and get it in! |
|
Thank you again @GYHHAHA for the pull request, sorry it took so long to get in!! This is an awesome improvement. 🚀 |
rowanc1
changed the title
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I find when we render the text with
\nand space, it will only be considered as single space since the default html behavior. I have a quick fix. The reason we use the font-mono is we have to keep the original character width the same to copy with some formatted output like NumPy array and pandas Series. Besides, the current margin for the code blocks is too big, and I checked the directive block margin is m-4, thus it much better to change this for unified visual experience. @rowanc1Here is the contrast:
---------------------------------Thanks!