Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: fixing jupyterhub urls #166

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Aug 8, 2020

fixes a bug uncovered by @rroggenkemper where jupyterhub launch URLs didn't get the right branch

@codecov-commenter
Copy link

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files           2        2           
  Lines         235      235           
=======================================
  Hits          215      215           
  Misses         20       20           
Flag Coverage Δ
#pytests 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_book_theme/launch.py 91.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00e5df...cd72fa7. Read the comment docs.

@choldgraf choldgraf changed the title fixing jupyterhub urls 🐛 BUG: fixing jupyterhub urls Aug 8, 2020
@choldgraf choldgraf merged commit 6439b66 into executablebooks:master Aug 8, 2020
@choldgraf choldgraf deleted the text-selection branch August 8, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants