Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing examples so they pass all tests #62

Closed
3 tasks done
0xbarrett opened this issue Sep 7, 2016 · 6 comments
Closed
3 tasks done

Fix existing examples so they pass all tests #62

0xbarrett opened this issue Sep 7, 2016 · 6 comments

Comments

@0xbarrett
Copy link
Contributor

0xbarrett commented Sep 7, 2016

  • Anagram: Fix 1 failing test
  • Leap: Fix 1 failing test
  • Leap: Fix 2 compiler warnings
@ryanplusplus
Copy link
Member

I think the issue with Hello World is that a stub is provided named hello_world.c. When you try to rename example.c to hello_world.c it fails and so runs the tests with the empty implementation and fails all 3 tests. When I tested by removing hello_world.c and example.c all tests pass.

@ryanplusplus
Copy link
Member

I don't see any failures for Anagram. What failure are you seeing?

@0xbarrett
Copy link
Contributor Author

0xbarrett commented Sep 8, 2016

Yep, good call about Hello World. As for Anagram, I'm getting:
anagram.c:163:test_multiple_anagrams:FAIL: Expected 3 Was 0 on OS X with LLVM 8.0.0.
...
However, on Ubuntu 16.04 with GCC 5.4.0, everything passes.

@arcuru
Copy link
Contributor

arcuru commented Sep 13, 2016

I can't get a failure for Anagram either (Ubuntu 12.04 & 16.04). I even tried it using GCC 4.8, which I think I heard was the version on Travis (?) but that worked fine as well.

I will take a more in-depth look tomorrow and test the failure on Travis.

We need to get this running before putting more exercises in. #71 wouldn't even compile, one of the test names was wrong.

@0xbarrett
Copy link
Contributor Author

Ok, I'm not sure what was going on before, but Anagram is now working for me. Maybe fed3ddf fixed it?

@ryanplusplus
Copy link
Member

I think it's quite likely that it did. I think this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants