Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex Numbers: Tests mix up Expected and Actual results, and unclear about requiring floats rather than rationals #520

Closed
SebAlbert opened this issue Nov 25, 2022 · 1 comment · Fixed by #570

Comments

@SebAlbert
Copy link

The tests for the Complex Numbers exercise have the Expected and Actual results in the wrong order in their (is) forms.
Moreover, it could be made more explicit that floats are expected when doing division rather than rational numbers (especially if the test suite output suggests that it would be the other way around).

@bobbicodes
Copy link
Member

Thanks again, I can't take the blame for this one because I didn't write it :)

This makes me wonder how many other test suites have the expected/actual args reversed. This must be a pretty common mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants