Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch script: wrong OS for mac #27

Closed
glennj opened this issue Oct 9, 2020 · 5 comments · Fixed by #28
Closed

fetch script: wrong OS for mac #27

glennj opened this issue Oct 9, 2020 · 5 comments · Fixed by #28
Labels
kind: bug User-facing incorrect behavior

Comments

@glennj
Copy link
Contributor

glennj commented Oct 9, 2020

In the fetch script, for "Darwin" platform, the OS variable is set to "mac". However, the platform part of the released tarball is "macosx".

Either the fetch script or the build process needs to be updated.
@glennj
Copy link
Contributor Author

glennj commented Oct 9, 2020

Other than that, the tool is working well for me: going through the very tedious process of verifying and accepting all the implemented tests in the Tcl track.

@ErikSchierboom
Copy link
Member

@glennj Wait for a sec! We'll submit a PR soon :)

@ErikSchierboom
Copy link
Member

Which you can build on.

@ErikSchierboom ErikSchierboom mentioned this issue Oct 9, 2020
Merged
@ErikSchierboom
Copy link
Member

@glennj Thanks for reporting! Fixed in #28

@ErikSchierboom
Copy link
Member

New release is being built: https://github.com/exercism/canonical-data-syncer/actions/runs/297974068

@ee7 ee7 changed the title Bug in fetch script: wrong OS for mac fetch script: wrong OS for mac May 10, 2021
@ee7 ee7 added the kind: bug User-facing incorrect behavior label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug User-facing incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix macos name exercism/configlet
3 participants
@glennj @ErikSchierboom @ee7