A big pile of exercises #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Holy exercises Batman! I will review ASAP! |
| suite | ||
| "DifferenceOfSquares" | ||
| [ suite | ||
| "Square the sum of the numbers up to the given number" |
There was a problem hiding this comment.
test descriptions should be all lowercase?
There was a problem hiding this comment.
Ah... I hadn't been consciously doing that, but I guess you're right.
|
@parkerl If you like, I can squash these "fix up" commits into their appropriate exercise specific commits when you're done skimming through. |
| suite | ||
| "triangleKind" | ||
| [ test | ||
| "Equilateral triangles have equal sides" |
|
@tgecho you are too fast! These look great. I am going to make you a member of the team and when you are ready you can merge this. Great work. |
|
🎉 Sounds good! You just caught me at a good moment :) Thanks! |
|
This should be good to go. |
|
Ok I have asked @kytrinyx to set you up...in the meantime I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I'm terribly sorry about dumping a pile of exercises in a single PR. Unfortunately, since adding an exercise requires modifying config.json and elm-package.json in a way that will cause parallel PRs to conflict any time one of them is merged.
If you have the slightest concern about one or more of the commits, just let me know and I'll yank them out of the branch so you can merge the rest. Otherwise I don't want to waste any reviewer time waiting for me to update parallel PRs so you can merge each one safely.
Thanks for your patience @parkerl !