Fix the width of comments section on the submissions page.

[nisusam]

Fixes: #3057

[coveralls]

Coverage remained the same at 82.613% when pulling 01970bc on nisusam:3057_horizontal_split_comments_section into b778f4f on exercism:master.

[coveralls]

Coverage remained the same at 82.613% when pulling 360ae65 on nisusam:3057_horizontal_split_comments_section into b778f4f on exercism:master.

[kytrinyx]

Would you please include a screenshot of the before/after?

[nisusam]

@kytrinyx please see the following screenshots for #3057

Screenshots Before Fix

• Without Comments

• With Comments

Screenshots After Fix

• Without Comments

• With Comments

[kotp]

@nisusam it looks like some conflicts happen, can you rebase from master and resolve these?

[coveralls]

Coverage remained the same at 82.667% when pulling fdf7ee0 on nisusam:3057_horizontal_split_comments_section into 8ccf8fd on exercism:master.

[Insti]

Are the Gem updates a necessary part of this patch?

[nisusam]

@kotp @Insti fa5be96 has updated application.css, which has used updated version of bootstrap-sass and font-awesome-sass.

I locked the versions of both in Gemfile to avoid the conflicts in future.

[bradhvr]

Hi @nisusam, just so I understand is there something I should have done differently? I'm kind of a novice with some of this. I recall having to install bootstrap-sassand font-awesome-sass separately when trying to set up my development environment.

This is from my Gemfile.lock:

bootstrap-sass (3.3.6)
font-awesome-sass (4.5.0)

[nisusam]

@bradhvr Since the version in Gemfile was not specified, when you ran bundle install bundler fetched the latest version for you, which in turn updated the compiled css.

[bradhvr]

Sorry, I'm still a little confused. Wouldn't the change to the compiled css be there because I made a change to application.scss? Compass updated application.css with my change and added the .highlight class.

#3072 also contains some changes to various compiled css based on my modifications.

[tejasbubane]

@bradhvr Agreed. The application.css should reflect your css changes, but this file in your commit has bootstrap version upgraded to 3.3.7 and fontawesome to 4.6.2.

This is a little odd since the version in Gemfile.lock is 3.3.6 for bootstrap and 4.5.0 for font-awesome.

[tejasbubane]

My initial guess is not running compass with bundle exec picked up the latest version of these gems installed on your machine, but I may be wrong here.

[Insti]

If the gemfile modifications are relevant, that's fine but I'd prefer to see them in a separately documented PR rather than bundled with the PR for a minor css change.

[bradhvr]

Oh ok, thanks for the explanation @tejasbubane! The CONTRIBUTING.md file doesn't say to run compass with bundle exec. Should it?

[tejasbubane]

@bradhvr I am not exactly sure if that is the cause. bootstrap and font-awesome are being required here and imported here.

PS: This would no longer be an issue once #2949 is merged.

[Insti]

The CONTRIBUTING.md file doesn't say to run compass with bundle exec. Should it?

Yes.

[Insti]

@nisusam can you untangle the Gem updates from the comments width changes and make a new PR for them please.

[tejasbubane]

Added bundle exec for compass in #3075

[nisusam]

@Insti Removed the Gemfile changes. I'll send them in a separate PR after these changes merged.

[coveralls]

Coverage remained the same at 82.667% when pulling e39e16d on nisusam:3057_horizontal_split_comments_section into 8ccf8fd on exercism:master.

[kytrinyx]

I've merged this locally in 3d26bbf