Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that port 8000 must be used for lineman reloading #3431

Merged
merged 1 commit into from Mar 25, 2017

Conversation

@nilbus
Copy link
Contributor

@nilbus nilbus commented Mar 25, 2017

Using port 4567, I couldn't figure out why my JS wouldn't reload with lineman building things for me. Hopefully this will help others later who hit the same problem.

@kotp
Copy link
Member

@kotp kotp commented Mar 25, 2017

Can someone verify this is indeed a requirement for this specific port number? A reference perhaps? It feels to me that it should be configurable to match whatever rackup is set up to.

@nilbus
Copy link
Contributor Author

@nilbus nilbus commented Mar 25, 2017

It seems to be convention, documented all over docs/setting-up-local-development.md, and hard-coded in the lineman config, frontend/config/application.coffee.

@nilbus
Copy link
Contributor Author

@nilbus nilbus commented Mar 25, 2017

docker-compose.yml also uses 4567, consistent with everything else.

That's not to say it couldn't be changed, but the default rackup port and default puma port aren't the same.

@kytrinyx kytrinyx merged commit b2212cb into exercism:master Mar 25, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.395%
Details
@kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Mar 25, 2017

Thanks, @nilbus.

@nilbus nilbus deleted the nilbus:document-reloading-port branch Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.