Overhaul experiment result stats page #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at review lengths day-by-day is not useful. This aggregates all days for the same period.
Looking at review lengths day-by-day is not useful.
This was fun to watch during the experiment but is not useful afterward. The variations by day aren't a meaningful variable in the experiment.
ParticipationStats already knows the dates that we are passing in. Why require they be passed?
Moving away from date-based charts.
Because of the nature of the counting query, users who submitted 0 comments during a period were not represented in the statistics. This was apparent because the number of comments per user in each period was never reported to be less than 1. This is difficult to accomplish in the original counting query, so instead this patch fills 0s for each participating user (who commented at least once during the experiment period) who isn't already represented by a comment count.
Trying to fit all data into the graph makes none of the meaningful data visible. You can still zoom out to see the full dataset.
Conflicts: app/routes/stats.rb The side stats menu is now selecting tracks with some number of implementations rather than problems.
|
Leaving the |
nilbus
changed the title
|
This is pretty sweet. Thanks for taking the time to make this more understandable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in exercism/discussions#123
Page: /stats
Changes
Graph Before
Graph After
Explanation Preview