-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue #57 #58
Conversation
@@ -33,7 +33,7 @@ For installation and learning resources, refer to the | |||
Run the tests by executing the test script. | |||
|
|||
``` | |||
$ groovy ./HelloWorldSpec.groovy | |||
$ groovy ./GrainsSpec.groovy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this get generated via the configlet generate . --only grains
command?
If not it looks like we need to open an issue to fix the template so that it uses the name of the exercise in the code example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it was me.
I'm still new to the project and didn't know that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that's fine. As long as we get the readme template fixed, it will come out right next time we generate the README.
@@ -0,0 +1,10 @@ | |||
class Phrase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to do it in this pull request, but we should make the file names match the name of the exercise to make it easier to do automation (like refer to the files in the README generation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks.
Thanks so much, @m-a-ge 🌷 |
Resolves #57
No test were lost, I've double checked