-
-
Notifications
You must be signed in to change notification settings - Fork 738
Improve instructions and tests for Remote Control Competition exercise #2283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve instructions and tests for Remote Control Competition exercise #2283
Conversation
7d9f501 to
e107e95
Compare
e107e95 to
b91c83d
Compare
|
Hi @kytrinyx, any advice on how to get this to the next step? 🙂 |
|
@eneuschild I recommend starting a conversation on the forum: https://forum.exercism.org/ In the past few months, most successful contributions happen by first discussing on the forum, in order to get clarity on what, exactly, the problem is, as well as how to approach resolving it. Once that is done, opening a PR is more of a formality. |
|
@eneuschild I just saw your post in the forum (https://forum.exercism.org/t/getting-pr-to-java-track-reviewed/4913). I'm not a track maintainer, so I'm not the right person to review this. @andrerfcsantos Do you know what the status is in the Java track these days? |
|
Thanks for the pointers, @kytrinyx! 💐 I'll try to stick to that process in the future! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look sensible. I would recommend to also make the tests changes in THIS PR, because otherwise they become unrelated changes.
- adapt instructions to match new tests - change ranking semantics to more intuitive more-wins-ranks-higher order
|
@SleeplessByte Thanks for your feedback! Please have another look! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Improve instructions and tests for Remote Control Competition exercise
Issue #2164 points out that Remote Control Competition's instructions don't match its tests very well. This PR is an attempt to improve this.
Completing each instruction subsection now increases the number of passing tests, which wasn't given previously.
Open Questions
configletto maintain README files. Am I understanding correctly that this isn't really applicable here because this exercise is not part of the more generic problem specifications? 🤔Reviewer Resources:
Track Policies