Skip to content

Conversation

@eneuschild
Copy link
Contributor

@eneuschild eneuschild commented Mar 14, 2023

Improve instructions and tests for Remote Control Competition exercise

Issue #2164 points out that Remote Control Competition's instructions don't match its tests very well. This PR is an attempt to improve this.

Completing each instruction subsection now increases the number of passing tests, which wasn't given previously.

Open Questions

  • I have not yet touched the tests themselves, as I feel this would be too big a change for a single (first) PR. Would you agree?
    • Update: Since @SleeplessByte disagreed with this assessment, I have now introduced more tests that gradually guide the student to a complete solution.
  • The way I understand the Updating the README section of the CONTRIBUTING.md, I should be running configlet to maintain README files. Am I understanding correctly that this isn't really applicable here because this exercise is not part of the more generic problem specifications? 🤔

Reviewer Resources:

Track Policies

@eneuschild eneuschild marked this pull request as ready for review March 14, 2023 14:00
@eneuschild eneuschild force-pushed the improve_remote_control_competition_instructions branch from 7d9f501 to e107e95 Compare March 30, 2023 15:34
@eneuschild eneuschild force-pushed the improve_remote_control_competition_instructions branch from e107e95 to b91c83d Compare March 30, 2023 15:36
@eneuschild
Copy link
Contributor Author

Hi @kytrinyx, any advice on how to get this to the next step? 🙂

@kytrinyx
Copy link
Member

kytrinyx commented Apr 1, 2023

@eneuschild I recommend starting a conversation on the forum: https://forum.exercism.org/

In the past few months, most successful contributions happen by first discussing on the forum, in order to get clarity on what, exactly, the problem is, as well as how to approach resolving it. Once that is done, opening a PR is more of a formality.

@kytrinyx
Copy link
Member

kytrinyx commented Apr 1, 2023

@eneuschild I just saw your post in the forum (https://forum.exercism.org/t/getting-pr-to-java-track-reviewed/4913). I'm not a track maintainer, so I'm not the right person to review this.

@andrerfcsantos Do you know what the status is in the Java track these days?

@eneuschild
Copy link
Contributor Author

Thanks for the pointers, @kytrinyx! 💐 I'll try to stick to that process in the future! 🙂

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look sensible. I would recommend to also make the tests changes in THIS PR, because otherwise they become unrelated changes.

- adapt instructions to match new tests
- change ranking semantics to more intuitive more-wins-ranks-higher order
@eneuschild eneuschild changed the title make instructions for Remote Control Competition more helpful Improve instructions and tests for Remote Control Competition exercise Apr 5, 2023
@eneuschild
Copy link
Contributor Author

@SleeplessByte Thanks for your feedback!
I have now added some more tests that allow a more gradual approach to a working all-green solution.

Please have another look! 🙂

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants