Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests and makefile to use Jest's "test" method #315

Closed
matthewmorgan opened this issue Jul 1, 2017 · 5 comments
Closed

Update tests and makefile to use Jest's "test" method #315

matthewmorgan opened this issue Jul 1, 2017 · 5 comments

Comments

@matthewmorgan
Copy link
Contributor

Jest is capable of using Jasmine's it and xit methods, but has its own test and xtest. I opened this issue to see what @exercism/ecmascripts think about switching from the Jasmine style to the Jest style for this track. Should we bother, or leave things as they are?

@joeljuca
Copy link
Contributor

joeljuca commented Jul 1, 2017

If we're going to switch, it makes sense to switch everything - including the current test codebase, to Jest. I mean, if we're going to support Jest's test/xtest, we should completely rip out Jasmine from the project and stick with Jest instead.

@matthewmorgan
Copy link
Contributor Author

matthewmorgan commented Jul 3, 2017

@joelwallis I agree with you completely. If we make the change, we should change it everywhere.

If no one has any objections, let's say:

Success Criteria:

Any other @exercism/ecmascripts care to weigh in?

@rchavarria
Copy link
Contributor

If we switched to Jest, let's go Jest.

Beside specs and Makefile (to replace xtest with test). I think there is some occurrence in any doc about how to run tests, so docs should be checked too.

@matthewmorgan
Copy link
Contributor Author

matthewmorgan commented Jul 3, 2017

Ah good point 😁 That change will need to be made here: https://github.com/exercism/ecmascript/edit/master/docs/EXERCISE_README_INSERT.md

(I have updated the success criteria to include this change.)

@tejasbubane
Copy link
Member

Good point @matthewmorgan 👍 All jest docs seem to be using test instead of it. Although it they seem aliases to me, it makes sense to switch to the jest-style.

Also jest seems to be moving away from jasmine in future versions (jestjs/jest#3668), although I don't think they will remove the it syntax in near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants