Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary search tree #739

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Conversation

depial
Copy link
Contributor

@depial depial commented May 24, 2024

The runtests.jl include explicit testing of instantiation and searching (making up the first two test groups) which go beyond the tests in canonical-data.json.

I do have another testset which strictly follows canonical-data.json, and it can be used if instantiation and searching isn't explicitly tested (in fact, a non-mutable struct could be used), but I don't think that would be in the spirit of the exercise.

Other notes:

  • The testest uses indentation to signify levels of the binary tree which are being tested.
  • Difficulty is set at 8 due to use of mutable struct and tree traversal
  • Field access methods have been supplied in the stub, but the struct definition is left to the student.

@depial depial mentioned this pull request May 24, 2024
10 tasks
Lowered difficulty level to 6
@ErikSchierboom
Copy link
Member

@depial I'll let @cmcaine look at the Julia code. If this isn't reviewed in a week or so, please ping me.

@depial
Copy link
Contributor Author

depial commented Jul 2, 2024

@ErikSchierboom there still hasn't been any further review. I think this is the exercise that is the most involved, as far as the code goes, so if you think it would be easier, I could try opening a PR with an exercise that has more straightforward code, and we could leave this one for later?

@ErikSchierboom
Copy link
Member

I will look at this next week when I return to work!

@ErikSchierboom ErikSchierboom merged commit af7e017 into exercism:main Jul 9, 2024
10 checks passed
@ErikSchierboom
Copy link
Member

Thanks!

@depial
Copy link
Contributor Author

depial commented Jul 9, 2024

Cheers!

@depial depial deleted the binary-search-tree branch July 9, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants