-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary search tree #739
Merged
Merged
Binary search tree #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Lowered difficulty level to 6
@ErikSchierboom there still hasn't been any further review. I think this is the exercise that is the most involved, as far as the code goes, so if you think it would be easier, I could try opening a PR with an exercise that has more straightforward code, and we could leave this one for later? |
I will look at this next week when I return to work! |
ErikSchierboom
approved these changes
Jul 9, 2024
Thanks! |
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
runtests.jl
include explicit testing of instantiation and searching (making up the first two test groups) which go beyond the tests incanonical-data.json
.I do have another testset which strictly follows
canonical-data.json
, and it can be used if instantiation and searching isn't explicitly tested (in fact, a non-mutable struct could be used), but I don't think that would be in the spirit of the exercise.Other notes: