Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify language-list instructions for add_language and remove_language #617

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Modify language-list instructions for add_language and remove_language #617

merged 2 commits into from
Aug 22, 2023

Conversation

m-dango
Copy link
Member

@m-dango m-dango commented Aug 21, 2023

No description provided.

kotp
kotp requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to reflect the remove and add addition language portions.

Currently it describes one thing, but not the other, and it was surprising to see the additional change.

kotp
kotp approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change requested, but approving, since the change while informative, and helpful, is not really critical.

@m-dango m-dango force-pushed the language-list-instructions-fix branch from 2915a1f to b56cd7d Compare August 22, 2023 12:30
@m-dango m-dango force-pushed the language-list-instructions-fix branch from b56cd7d to 8f9b29b Compare August 22, 2023 12:31
@m-dango m-dango changed the title Fix language-list instructions for remove_language Modify language-list instructions for add_language and remove_language Aug 22, 2023
@m-dango m-dango merged commit 3331fd4 into exercism:main Aug 22, 2023
23 checks passed
@m-dango m-dango deleted the language-list-instructions-fix branch August 22, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotp kotp kotp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-dango @kotp