Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for new exercise: ResistorColor (Resistor Series #1) #1458

Closed
emcoding opened this issue Feb 10, 2019 · 17 comments · Fixed by #1457
Closed

Proposal for new exercise: ResistorColor (Resistor Series #1) #1458

emcoding opened this issue Feb 10, 2019 · 17 comments · Fixed by #1457

Comments

@emcoding
Copy link
Contributor

emcoding commented Feb 10, 2019

Resistors have color bands. Each color represents a number. Resistor can have up to 6 bands, and together they describe the resistance value in Ohms, together with the tolerance and the temperature coefficient.

image

We're planning to have a series of Resistor-* exercises, that are building up to decoding 4-6 band resistor color codes.

  1. The new exercise ResistorColor
    The first and most basic one is just reading the (first) band's color from an array and return its numeric value.
    schermafbeelding 2019-02-10 om 13 15 39

See PR #1457

  1. This is supposed to be part of a series of Resistor related exercises, in ascending complexity:
  • Reading the first two bands and combine them to a number
  • Reading TriBand, and returning a value in Ω (Ohms) or K Ω
  • Reading 4 to 6 bands, returning the value in Ohms, the tolerance and the temperature coefficient. In those resistors, the meaning of the 3rd and 4th band is depending on the total number of bands.
    Coming soon!
@rpottsoh
Copy link
Member

  1. Will you be getting into combining resistors in series and/or in parallel?
  2. Will the solution of one exercise be required before proceeding to the next?
  3. Will this first exercise be recommended as a core exercise and then each of the follow-ons as a side?

Looking forward to learning more about what the forward looking plan might be.

@emcoding
Copy link
Contributor Author

@rpottsoh :-))))

  1. Not even thought of it. Great idea!
  2. My thinking is: not in the first exercises. But in the more advanced ones, they can be, yes. Currently only core exercises can unlock other, so it also depends on how a track implements them. But for instance in Ruby, including one in the other can be a nice showcase for mixins.
  3. Also, depending on the track. For instance for Ruby, the second one is more appropriate as a core exercise than the first one. I can imagine that it's good to have the second one as a core, if you want to have it included. On the other hand, it's also possible that the student writes the code to be mixed in at the moment that they need it in the later exercise. In general, I don't think we should force rules on how tracks implement such a series, but you're right, it would be nice to offer a optional plan. 👌

Thoughts?

@rpottsoh
Copy link
Member

2. including one in the other can be a nice showcase for mixins

I am not sure I follow your meaning for mixins.

emcoding added a commit to exercism/website-copy that referenced this issue Mar 10, 2019
We are about to merge the new exercise Resistor Colors.
It's introduced as a side exercise first, so I don't expect much mentoring requests, but just in case, here's some preliminary Mentor Notes.  They will need evaluating after we've seen some solutions submitted. 

References:
Ruby PR https://github.com/exercism/ruby/pulls
Problem Specifications: exercism/problem-specifications#1466
This exercise is meant to be part of a series of Resistor exercises, building up to decoding up to 6 colors: exercism/problem-specifications#1458, and starting with just one color in Resistor Series nr 1
@emcoding
Copy link
Contributor Author

emcoding commented Jul 12, 2019

@rdai
Copy link

rdai commented Sep 17, 2020

I am doing this on exercism dart track, https://exercism.io/my/solutions/3e1b3f982e614293b36ed824f78821bc

I am not sure the objective of the exercise is very clear as it is stated.

@kotp
Copy link
Member

kotp commented Sep 17, 2020

@rdai what are your doubts? What isn't clear? Perhaps discuss it with a mentor on the exercise there? If there are still questions or a way to make it clearer, then a pull request could be made on this repository (this repository is currently "frozen" with the exception of bug fixes, though). That doesn't mean that the Dart track couldn't have the new improved version, in the meantime.

@rdai
Copy link

rdai commented Sep 18, 2020

Thanks, I was able to complete it myself but running it and reverse engineer from the test results. I was not sure what the exercise is asking me to do. I see a lot descriptions but not a statement asking me to do something. Thanks. I will look at the pull request.

@kotp
Copy link
Member

kotp commented Sep 18, 2020

@rdal keep in mind that this is the first of a series of exercises regarding Resistors. So the minimal information, the incomplete specification, that is a "feature" of the exercise. Still, it should end up being clear, so if there are problems with it that we can fix, it would be a good addition.

@rdai
Copy link

rdai commented Sep 18, 2020

@kotp I now see I am not the first one that reported this and this is even already merged into something, just not reflecting on the main site yet. #1546

Thanks, I will leave this post alone now. 👍

@kotp
Copy link
Member

kotp commented Sep 18, 2020 via email

@sergarb1
Copy link

Hi! I want to make a request. In this provle, provided test have lowercase color names, but in explanation, first letter is upper case. In my opinion it confuses students.

Can we change problema explanation and show only lowercase color names?

Regards!

@kotp
Copy link
Member

kotp commented Nov 14, 2020

@sergarb1 Could you make a pull request to show what you would like changed?

@BryanJBryce
Copy link

@rdai Yeah, there is no question, it need to be rewritten, it's pretty bad.

@BryanJBryce
Copy link

@kotp Is there a timeline for when this gets unfrozen?

@SleeplessByte
Copy link
Member

@BryanJBryce it was unfrozen in October: #1686

@happinesssam
Copy link

The exercise is very badly written, giving little to no clue on what is actually expected. By reading the test it's expecting a string array with the color names in lower case ordered to match the mnemonic and a colorCode method that will return the order or a color when passed the string.
It needs to say something like that otherwise it's just going to confuse people and put them off. The early questions really need to be simple and easy to understand.

@SleeplessByte
Copy link
Member

Hi @happinesssam, we're currently working on V3 of Exercism which will be launched in about 48 days (see: https://countdown.exercism.io/). In v3-enabled tracks, a new set of exercises (called concept exercises) has been written to facilitate exactly that. Less confusing, streamlines goals, longer explanations and more help.

The exercise resistor-color is not part of that. That said, this exercise has been around for 2 years. If you'd like to provide constructive feedback to make this exercise better, please open a new issue or PR in this repository or the track you're currently taking part in.

I'll lock this issue to prevent further posts on old issues like this and stimulate fresh discussions in new issues.

@exercism exercism locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants