Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump DavidAnson/markdownlint-cli2-action from 5.1.0 to 7.0.0 #2096

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 7, 2022

Bumps DavidAnson/markdownlint-cli2-action from 5.1.0 to 7.0.0.

Commits
  • e3969ef Regenerate index.js after dependency updates.
  • a68af9a Update documentation and example to reference @​v7.
  • 2768abd Bump markdownlint-cli2 from 0.4.0 to 0.5.1 (#16)
  • a149eac Bump @​actions/core from 1.9.0 to 1.9.1 (#15)
  • eb5d3a1 Bump tj-actions/changed-files from 24 to 25 (#14)
  • 16d9da4 Bump eslint from 8.20.0 to 8.21.0 (#13)
  • 0c1223c Update npm test script to ignore differences in generated file dist/index.js ...
  • 6f8162e Fix job name in test workflow.
  • 5886d8c Add example workflow demonstrating linting only changed files (closes #12).
  • f9beccb Create dependabot.yml to enable automatic version updates for GitHub Actions ...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 7, 2022 04:17
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Label used by Dependabot to indicate the ecosystem its PR affects. labels Sep 7, 2022
@ErikSchierboom
Copy link
Member

Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/DavidAnson/markdownlint-cli2-action) from 5.1.0 to 7.0.0.
- [Release notes](https://github.com/DavidAnson/markdownlint-cli2-action/releases)
- [Commits](DavidAnson/markdownlint-cli2-action@744f913...e3969ef)

---
updated-dependencies:
- dependency-name: DavidAnson/markdownlint-cli2-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/DavidAnson/markdownlint-cli2-action-7.0.0 branch from 5902599 to e6b46f5 Compare October 5, 2022 17:32
@kytrinyx
Copy link
Member

kytrinyx commented Oct 6, 2022

@ErikSchierboom This is updating the markdown linter, and a new linting rule causes CI to fail.

This is the bit that is failing (in exercises/affine-cipher/description.md):

[comment]: # ( monoalphabetic as spelled by Merriam-Webster, compare to polyalphabetic ) 

This was added in #1911 as a comment (not a link) in order to preserve some history about reasoning/decisions.

I think the right call here is to add a design.md document where this information can live, and delete the comment from the file. Thoughts?

We will need to wait to merge this PR until that is sorted.

@ErikSchierboom
Copy link
Member

I think the right call here is to add a design.md document where this information can live, and delete the comment from the file. Thoughts?

Agreed. That seems like a much more elegant solution than a comment in the markdown.

@kytrinyx
Copy link
Member

kytrinyx commented Oct 7, 2022

Cool, in a week or so #2108 will have had enough time to garner objections (it's looking very uncontroversial), so I'll take care of it as part of that issue.

@wolf99 wolf99 mentioned this pull request Nov 2, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 3, 2022

Looks like DavidAnson/markdownlint-cli2-action is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Nov 3, 2022
@dependabot dependabot bot deleted the dependabot/github_actions/DavidAnson/markdownlint-cli2-action-7.0.0 branch November 3, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Label used by Dependabot to indicate the ecosystem its PR affects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants